Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Target Root Better #7837

Merged
merged 5 commits into from
Nov 19, 2020
Merged

Check Target Root Better #7837

merged 5 commits into from
Nov 19, 2020

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Nov 17, 2020

What type of PR is this?

Cleanup

What does this PR do? Why is it needed?

  • Checks consistency of target root with finalized checkpoint better.
  • Remove debug log.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas requested a review from a team as a code owner November 17, 2020 07:33
@nisdas nisdas added Ready For Review A pull request ready for code review release-target Security Security Related Issues labels Nov 17, 2020
terencechain
terencechain reviewed Nov 17, 2020
View reviewed changes
beacon-chain/sync/validate_aggregate_proof.go Outdated

attSlot := signed.Message.Aggregate.Data.Slot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move attSlot := signed.Message.Aggregate.Data.Slot to line 120? (after AttestationPreState)

@prylabs-bulldozer prylabs-bulldozer bot merged commit 8a256de into master Nov 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the checkBetter branch November 19, 2020 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terencechain terencechain terencechain approved these changes

@shayzluf shayzluf Awaiting requested review from shayzluf

@0xKiwi 0xKiwi Awaiting requested review from 0xKiwi

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon

Assignees
No one assigned
Labels
Ready For Review A pull request ready for code review Security Security Related Issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nisdas @terencechain