Refactor scoring service

[farazdagi]

What type of PR is this?

Other / Refactoring

What does this PR do? Why is it needed?

• Extracted from Peer status peer scorer #7480, adds the following changes:
  • Removes weight from bad responses scorer (score is penalty, so no weight is necessary)
  • Removes contexts from scorers. We have this anti-pattern everywhere, when we are passing ctx to control life-time of the service: fortunately, ctx in scorers are not used at all, so easy to refactor/remove.
  • Adds Scorer interface, makes sure that both scorers and scorer service comply to it. This means that we can use individual scorers, and when necessary can query service object, which will traverse all registered scorers. For ex, IsBadPeer(pid) when called on service object will traverse all the individual scorers and mark peer as bad if any of the scorers mark it as such.
  • Adds weights to individual scorers, allowing us to control how much each individual scorer contributes to the overall score (also allows having scorers with 0 weight - such scorers are useful individually, but not contributing to overall score).

Which issues(s) does this PR fix?

N/A

Other notes for review