Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Deposit Prune Proof Panic #7851

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Handle Deposit Prune Proof Panic #7851

merged 1 commit into from
Nov 18, 2020

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Nov 18, 2020

What type of PR is this?

Bug Fix

What does this PR do? Why is it needed?

  • Fixes and off by 1 error when pruning deposit proofs, the method did not
    correctly handle the last possible index to prune and instead panicked.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas added the Ready For Review A pull request ready for code review label Nov 18, 2020
@nisdas nisdas requested a review from a team as a code owner November 18, 2020 11:50
@nisdas nisdas merged commit e1dd532 into master Nov 18, 2020
@delete-merged-branch delete-merged-branch bot deleted the handlePanic2 branch November 18, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farazdagi farazdagi farazdagi approved these changes

@shayzluf shayzluf Awaiting requested review from shayzluf

@0xKiwi 0xKiwi Awaiting requested review from 0xKiwi

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon

Assignees
No one assigned
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nisdas @farazdagi