Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Test For Earliest Voting Block #7882

Merged
merged 2 commits into from
Nov 21, 2020
Merged

Add Test For Earliest Voting Block #7882

merged 2 commits into from
Nov 21, 2020

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Nov 21, 2020

What type of PR is this?

Test addition.

What does this PR do? Why is it needed?

  • Adds a test case for earliest voting block, to test 2 cases mainly pre-genesis and after genesis is set but chain has
    not started yet.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas requested a review from a team as a code owner November 21, 2020 11:09
@nisdas nisdas added Ready For Review A pull request ready for code review OK to merge labels Nov 21, 2020
rkapka
rkapka approved these changes Nov 21, 2020
View reviewed changes
Copy link
Contributor

@rkapka rkapka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

beacon-chain/powchain/service_test.go Show resolved Hide resolved
@prylabs-bulldozer prylabs-bulldozer bot merged commit ac60ff2 into master Nov 21, 2020
@delete-merged-branch delete-merged-branch bot deleted the addTest branch November 21, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkapka rkapka rkapka approved these changes

@shayzluf shayzluf Awaiting requested review from shayzluf

@0xKiwi 0xKiwi Awaiting requested review from 0xKiwi

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon

Assignees
No one assigned
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nisdas @rkapka