Improve Slashing Protection for V1, More Tests and Observability #7934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
commented
Nov 24, 2020
validator/client/attest_protect.go
Outdated
| @@ -7,6 +7,8 @@ import ( | |||
|
|
|||
There was a problem hiding this comment.
Review carefully
| @@ -2,6 +2,7 @@ package client | |||
|
|
|||
There was a problem hiding this comment.
Look at all these tests!
| @@ -127,6 +127,49 @@ func (hd EncHistoryData) SetTargetData(ctx context.Context, target uint64, histo | |||
| return hd, nil | |||
| } | |||
|
|
|||
| // MarkAllAsAttestedSinceLatestWrittenEpoch returns an attesting history with specified target+epoch pairs | |||
| // since the latest written epoch up to the incoming attestation's target epoch as attested for. | |||
| func MarkAllAsAttestedSinceLatestWrittenEpoch( | |||
There was a problem hiding this comment.
Same logic as before, just changed to remove variable shadowing risk
prysm/validator/client/attest_protect.go
Line 135 in dc897a2
rauljordan
added
Priority: Critical
rauljordan
requested review from
prestonvanloon,
rkapka,
shayzluf and
terencechain
prestonvanloon
approved these changes
Nov 24, 2020
terencechain
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Slashing protection, in current
master, lives with some really serious problems. Although most of these issues are patched in #7848, that PR needs time to be tested in pre-production environments before making into the master branch due to how radical it is and how much it changes. Unfortunately, we still have some bugs today in detecting surround votes, which we have observed today in our internal infrastructure. The issues are with respect to false positives, meaning that local slashing protection detects certain attestations as slashable which are not. Moreover, we do not have enough logs available to help us understand the problem. This PR adds the following changes: