Refetch validating keys if no keys are fetched #8000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
changed the title
validator/client/validator.go
Outdated
| break | ||
| case <-ctx.Done(): | ||
| log.Debug("Context closed, exiting fetching validating keys") | ||
| return errors.New("context closed, no longer attempting to fetch validating keys") |
There was a problem hiding this comment.
Suggested change
| return errors.New("context closed, no longer attempting to fetch validating keys") | |
| return ctx.Err() |
I like ctx.Err() better here. Current error message sounds duplicated with the debug log
terencechain
previously approved these changes
Dec 10, 2020
# Conflicts: # validator/client/validator.go # validator/client/validator_test.go
prestonvanloon
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
When a validator starts with a remote wallet, the wallet can contain no keys. In such case the validator is stuck indefinitely on
WaitForActivation, and adding keys to the wallet does not unblock it.Which issues(s) does this PR fix?
N/A
Other notes for review
When redistributing keys by scaling up validator replicas, the safest way is to scale up validators first, and then assign keys to them. This will not work without the fix, as the new validator replicas will not fetch their keys.