Add Backup Webhooks to All Prysm Services With DBs #8025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
added
Enhancement
rauljordan
requested review from
farazdagi,
prestonvanloon,
shayzluf and
terencechain
rkapka
requested changes
Dec 3, 2020
rkapka
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
This PR adds backup webhook functionality to all Prysm services which use boltDB and prometheus by attaching an http handler to the service's monitoring http://host:port/db/backup. It abstracts the backup handler into its own shared package and extract common flags into the shared/flags/cmd.go file.
Which issues(s) does this PR fix?
No tracking issue