Resolve panic on shutdown with offline eth1 node #8033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
requested changes
Dec 3, 2020
There was a problem hiding this comment.
Please handle this in the appropriate place, we initiate our main eth1 event loop after the context is cancelled. The correct thing would be to check this in the correct place which is after
https://github.com/prysmaticlabs/prysm/blob/develop/beacon-chain/powchain/service.go#L257
|
@nisdas thanks |
nisdas
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
What does this PR do? Why is it needed?
When a node that already had a genesis state is started with an offline eth1 node it panics on shutdown somtimes.
this Pr aims to fix this issue
Which issues(s) does this PR fix?
Fixes #8014