Return error on AttestingIndices bitfield length check
#8285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
previously approved these changes
Jan 19, 2021
prestonvanloon
requested changes
Jan 19, 2021
| @@ -65,14 +68,17 @@ func ConvertToIndexed(ctx context.Context, attestation *ethpb.Attestation, commi | |||
| // """ | |||
| // committee = get_beacon_committee(state, data.slot, data.index) | |||
| // return set(index for i, index in enumerate(committee) if bits[i]) | |||
| func AttestingIndices(bf bitfield.Bitfield, committee []uint64) []uint64 { | |||
| func AttestingIndices(bf bitfield.Bitfield, committee []uint64) ([]uint64, error) { | |||
| if bf.Len() > uint64(len(committee)) { | |||
There was a problem hiding this comment.
This should return an error if they are not equal.
…rysm into return-err-committee-len
prestonvanloon
approved these changes
Jan 20, 2021
|
|
Codecov Report
@@ Coverage Diff @@
## develop #8285 +/- ##
==========================================
Coverage ? 57.09%
==========================================
Files ? 449
Lines ? 31419
Branches ? 0
==========================================
Hits ? 17940
Misses ? 10689
Partials ? 2790 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Return error if attestation's bitfield length is greater than the committee length. This hardens and brings the defensive against invalid bitflied into the helper level
Which issues(s) does this PR fix?
N/A
Other notes for review
N/A