Rm forkchoice attestation verification #8301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
commented
Jan 20, 2021
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| if indexedAtt.AttestingIndices == nil { |
There was a problem hiding this comment.
This check was moved to IsValidAttestationIndices
terencechain
commented
Jan 20, 2021
| @@ -39,7 +39,6 @@ var ErrTargetRootNotInDB = errors.New("target root does not exist in db") | |||
| // | |||
| // # Update latest messages for attesting indices | |||
| // update_latest_messages(store, indexed_attestation.attesting_indices, attestation) | |||
| // TODO(#6072): This code path is highly untested. Requires comprehensive tests and simpler refactoring. | |||
There was a problem hiding this comment.
This issue has been closed a while ago
Codecov Report
@@ Coverage Diff @@
## develop #8301 +/- ##
==========================================
Coverage ? 57.09%
==========================================
Files ? 449
Lines ? 31522
Branches ? 0
==========================================
Hits ? 17996
Misses ? 10726
Partials ? 2800 |
rauljordan
approved these changes
Jan 20, 2021
| return nil, errors.New("nil attesting indices") | ||
| } | ||
| // Note that signature verification is ignored here because it was performed in sync's validation pipeline: | ||
| // validate_aggregate_proof.go and validate_beacon_attestation.go |
There was a problem hiding this comment.
Confirmed this is validated there indeed
prestonvanloon
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Remove forkchoice attestation signature verification as we should assume trusted input for the pipelines in fork choice. I opt in the cheaper verification for attesting indices. See more commentary in diff
More rationale: https://hackmd.io/LZONsUmKSReJTSUYQR88Rw?view
Which issues(s) does this PR fix?
N/A
Other notes for review
N/A