Refactor on_attestation return signature
#8310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Ready For Review
|
| if err != nil { | ||
| return errors.Wrap(err, "could not process attestation") | ||
| if err := s.onAttestation(ctx, att); err != nil { | ||
| errors.Wrap(err, "could not process attestation") |
There was a problem hiding this comment.
Oh man. Copy pasta failed. Surprising Goland didnt alert me for that...
There was a problem hiding this comment.
Thankfully we have static analysis!
prestonvanloon
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
on_attestationreturns([]uint64, error). The attesting indices[]uint64was never used. This PR removes itWhich issues(s) does this PR fix?
Fixes # N/A
Other notes for review
N/A