Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace bytes.Equal with assert.DeepEqual in tests #8318

Merged
merged 11 commits into from Jan 22, 2021
Merged

Replace bytes.Equal with assert.DeepEqual in tests #8318

merged 11 commits into from Jan 22, 2021

Conversation

rkapka
Copy link
Contributor

@rkapka rkapka commented Jan 22, 2021

What type of PR is this?

Test cleanup

What does this PR do? Why is it needed?

assert.DeepEqual works with byte arrays, which means we can replace bytes.Equal assertions in tests with our library.

Which issues(s) does this PR fix?

N/A

Other notes for review

N/A

@rkapka rkapka requested a review from a team as a code owner January 22, 2021 14:06
@rkapka rkapka added the Cleanup Code health! label Jan 22, 2021
@rkapka rkapka added OK to merge Ready For Review A pull request ready for code review labels Jan 22, 2021
farazdagi
farazdagi suggested changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@farazdagi farazdagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just couple of suggestions.

beacon-chain/db/kv/migration_archived_index_test.go Outdated Show resolved Hide resolved
beacon-chain/db/kv/migration_block_slot_index_test.go Outdated Show resolved Hide resolved
rkapka and others added 3 commits January 22, 2021 15:34
@rkapka @farazdagi
Update beacon-chain/db/kv/migration_archived_index_test.go
683283f 
Co-authored-by: Victor Farazdagi <simple.square@gmail.com>
@rkapka @farazdagi
Update beacon-chain/db/kv/migration_block_slot_index_test.go
03b60aa 
Co-authored-by: Victor Farazdagi <simple.square@gmail.com>
@rkapka
remove unused imports
788fd45
farazdagi
farazdagi suggested changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@farazdagi farazdagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While on it let's capitalize start of messages?

beacon-chain/core/state/skip_slot_cache_test.go Outdated Show resolved Hide resolved
beacon-chain/core/state/skip_slot_cache_test.go Outdated Show resolved Hide resolved
beacon-chain/core/state/skip_slot_cache_test.go Outdated Show resolved Hide resolved
beacon-chain/core/state/skip_slot_cache_test.go Outdated Show resolved Hide resolved
beacon-chain/db/kv/migration_archived_index_test.go Outdated Show resolved Hide resolved
beacon-chain/db/kv/migration_block_slot_index_test.go Outdated Show resolved Hide resolved
rkapka and others added 6 commits January 22, 2021 15:44
@rkapka @farazdagi
Update beacon-chain/core/state/skip_slot_cache_test.go
e4c59e5 
Co-authored-by: Victor Farazdagi <simple.square@gmail.com>
@rkapka @farazdagi
Update beacon-chain/core/state/skip_slot_cache_test.go
f239998 
Co-authored-by: Victor Farazdagi <simple.square@gmail.com>
@rkapka @farazdagi
Update beacon-chain/core/state/skip_slot_cache_test.go
898acd9 
Co-authored-by: Victor Farazdagi <simple.square@gmail.com>
@rkapka @farazdagi
Update beacon-chain/core/state/skip_slot_cache_test.go
81831e8 
Co-authored-by: Victor Farazdagi <simple.square@gmail.com>
@rkapka @farazdagi
Update beacon-chain/db/kv/migration_archived_index_test.go
3df41dc 
Co-authored-by: Victor Farazdagi <simple.square@gmail.com>
@rkapka @farazdagi
Update beacon-chain/db/kv/migration_block_slot_index_test.go
7dbd4dc 
Co-authored-by: Victor Farazdagi <simple.square@gmail.com>
@prylabs-bulldozer prylabs-bulldozer bot merged commit 7842fd9 into develop Jan 22, 2021
@delete-merged-branch delete-merged-branch bot deleted the bytes-equal branch January 22, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farazdagi farazdagi farazdagi approved these changes

@rauljordan rauljordan Awaiting requested review from rauljordan

@shayzluf shayzluf Awaiting requested review from shayzluf

@0xKiwi 0xKiwi Awaiting requested review from 0xKiwi

Assignees
No one assigned
Labels
Cleanup Code health! Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rkapka @farazdagi