Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle subscriber error #8341

Merged
merged 1 commit into from Jan 26, 2021
Merged

Handle subscriber error #8341

merged 1 commit into from Jan 26, 2021

Conversation

terencechain
Copy link
Member

What type of PR is this?

Cleanup

What does this PR do? Why is it needed?
Subscriber error was not handled in the select block. This handles it

Which issues(s) does this PR fix?

N/A

Other notes for review

N/A

@terencechain terencechain added the Ready For Review A pull request ready for code review label Jan 26, 2021
@terencechain terencechain self-assigned this Jan 26, 2021
@terencechain terencechain requested a review from a team as a code owner January 26, 2021 19:01
@rauljordan rauljordan merged commit 91fe32a into develop Jan 26, 2021
@rauljordan rauljordan deleted the handle-sub-error branch January 26, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan approved these changes

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon

@rkapka rkapka Awaiting requested review from rkapka

@nisdas nisdas Awaiting requested review from nisdas

Assignees

@terencechain terencechain

Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@terencechain @rauljordan