Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block validator buckets #8395

Merged
merged 3 commits into from Feb 4, 2021
Merged

Block validator buckets #8395

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9462e7
Block validator buckets
terencechain Feb 4, 2021
dac0261
add more buckets to blocked collector list
rauljordan Feb 4, 2021
2ebc470
Merge branch 'develop' into disable-validator-buckets
rauljordan Feb 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 15 additions & 1 deletion validator/db/kv/db.go
View file
Open in desktop
Expand Up @@ -33,6 +33,20 @@ var (
ProtectionDbFileName = "validator.db"
)

// blockedBuckets represents the buckets that we want to restrict
// from our metrics fetching for performance reasons. For a detailed
// summary, it can be read in https://github.com/prysmaticlabs/prysm/issues/8274.
var blockedBuckets = [][]byte{
deprecatedAttestationHistoryBucket,
lowestSignedSourceBucket,
lowestSignedTargetBucket,
lowestSignedProposalsBucket,
highestSignedProposalsBucket,
pubKeysBucket,
attestationSigningRootsBucket,
attestationSourceEpochsBucket,
}

// Store defines an implementation of the Prysm Database interface
// using BoltDB as the underlying persistent kv-store for eth2.
type Store struct {
Expand Down Expand Up @@ -171,5 +185,5 @@ func (s *Store) Size() (int64, error) {

// createBoltCollector returns a prometheus collector specifically configured for boltdb.
func createBoltCollector(db *bolt.DB) prometheus.Collector {
return prombolt.New("boltDB", db)
return prombolt.New("boltDB", db, blockedBuckets...)
}