Add prysm version to prometheus #8527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shared/version/metrics.go
Outdated
| ) | ||
|
|
||
| var prysmInfo = promauto.NewGauge(prometheus.GaugeOpts{ | ||
| Name: "prysm_info", |
There was a problem hiding this comment.
Suggested change
| Name: "prysm_info", | |
| Name: "prysm_version", |
or prysm_version_and_committ is fine too
Codecov Report
@@ Coverage Diff @@
## develop #8527 +/- ##
==========================================
Coverage ? 58.12%
==========================================
Files ? 460
Lines ? 32950
Branches ? 0
==========================================
Hits ? 19151
Misses ? 10894
Partials ? 2905 |
| }) | ||
|
|
||
| func init() { | ||
| prysmInfo.Set(float64(1)) |
There was a problem hiding this comment.
How does this work? It always sets the version to 1?
prestonvanloon
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Adds prysm version as prometheus metric
Which issues(s) does this PR fix?
Fixes #8516
Other notes for review
Also added commit hash