Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase default peer limit from 30 to 45 #8530

Merged
merged 4 commits into from
Mar 1, 2021
Merged

Increase default peer limit from 30 to 45 #8530

merged 4 commits into from
Mar 1, 2021

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Mar 1, 2021 •
edited

What type of PR is this?

Peering Cleanup

What does this PR do? Why is it needed?

  • A long overdue change, this bumps up the default peer limit to 45 from 30. Any user running a validator might eventually run into issues with only 30 peers. This gives a larger buffer for the average solo staker, so that they can find peers in subnets.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas requested a review from a team as a code owner March 1, 2021 05:17
@nisdas nisdas added the Ready For Review A pull request ready for code review label Mar 1, 2021
@prestonvanloon prestonvanloon changed the title Bump Up Peer Limit Increase default peer limit from 30 to 45 Mar 1, 2021
@prestonvanloon
Copy link
Member

Edited title for better visibility in release notes. Thanks!

@prylabs-bulldozer prylabs-bulldozer bot merged commit 8a27449 into develop Mar 1, 2021
@delete-merged-branch delete-merged-branch bot deleted the bumpPeerLimit branch March 1, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan approved these changes

@prestonvanloon prestonvanloon prestonvanloon approved these changes

@terencechain terencechain Awaiting requested review from terencechain

Assignees
No one assigned
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nisdas @prestonvanloon @rauljordan