Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Goland Standard "cmd" Pattern for Beacon-Chain Binaries #8540

Merged
merged 7 commits into from
Mar 2, 2021
Merged

Add Goland Standard "cmd" Pattern for Beacon-Chain Binaries #8540

merged 7 commits into from
Mar 2, 2021

Conversation

rauljordan
Copy link
Contributor

@rauljordan rauljordan commented Mar 2, 2021 •
edited

What type of PR is this?

Feature

What does this PR do? Why is it needed?

Based on https://hackmd.io/i_B-BH-NRDmDCIxRAsY6eg, we should align Prysm to more Golang standards, creating a standard cmd entrypoint for binaries.

@rauljordan rauljordan added the Cleanup Code health! label Mar 2, 2021
@rauljordan rauljordan self-assigned this Mar 2, 2021
@rauljordan rauljordan added the Ready For Review A pull request ready for code review label Mar 2, 2021
@rauljordan rauljordan marked this pull request as ready for review March 2, 2021 15:06
@rauljordan rauljordan requested a review from a team as a code owner March 2, 2021 15:06
@rauljordan rauljordan merged commit 090fbbf into develop Mar 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the beacon-cmd branch March 2, 2021 19:36
@rauljordan rauljordan mentioned this pull request Mar 3, 2021
Merged
@prestonvanloon prestonvanloon mentioned this pull request Dec 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestonvanloon prestonvanloon prestonvanloon approved these changes

@terencechain terencechain Awaiting requested review from terencechain

@rkapka rkapka Awaiting requested review from rkapka

Assignees

@rauljordan rauljordan

Labels
Cleanup Code health! Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rauljordan @prestonvanloon