Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Goland Standard "cmd" Pattern for Validator Binaries #8541

Merged
merged 12 commits into from
Mar 2, 2021

Conversation

rauljordan
Copy link
Contributor

What type of PR is this?

Feature

What does this PR do? Why is it needed?

Based on https://hackmd.io/i_B-BH-NRDmDCIxRAsY6eg, we should align Prysm to more Golang standards, creating a standard cmd entrypoint for binaries.

@rauljordan rauljordan requested a review from a team as a code owner March 2, 2021 15:20
@rauljordan rauljordan added Cleanup Code health! Ready For Review A pull request ready for code review labels Mar 2, 2021
@prestonvanloon
Copy link
Member

prestonvanloon commented Mar 2, 2021

Can you alias the previous targets so that this doesn't break any existing workflows?

Edit: I mean all of the targets, images, etc

@prestonvanloon
Copy link
Member

These were the previous targets

//validator:push_images_debug
//validator:push_images_alpine
//validator:push_images
//validator:image_bundle_debug
//validator:image_debug
//validator:image_bundle_alpine
//validator:image_bundle
//validator:image_with_creation_time
//validator:image_alpine
//validator:image
//validator:validator
//validator:go_default_test
//validator:go_default_library

@rauljordan
Copy link
Contributor Author

ok awesome, on it

validator/BUILD.bazel Outdated Show resolved Hide resolved
@rauljordan rauljordan merged commit cdea2de into develop Mar 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the validator-cmd branch March 2, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Code health! Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants