Add errcheck and gosimple linters #9729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
len() for nil slices is defined as zero
prestonvanloon
requested changes
Oct 5, 2021
|
hey @estensen , are you planning on completing this PR or should someone take it over? |
This reverts commit af69ca1.
|
@rkapka sorry for the delay. Still want to do this! |
|
Thanks for the response. You can remove the assertion and we will merge the PR. Thanks! |
This reverts commit 5fe8931.
prestonvanloon
approved these changes
Oct 22, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
Improve code quality
Which issues(s) does this PR fix?
#9371
Other notes for review