Add field roots for beacon state v3 #9914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
previously approved these changes
Nov 17, 2021
nisdas
previously approved these changes
Nov 17, 2021
|
Regarding |
|
@terencechain you will need to add an exception as we cant merge without gocheck passing. |
ah, forgot it's required, ready again |
|
Can you add in an exception for deadcode instead of the whole package for that particular struct ? |
nisdas
approved these changes
Nov 17, 2021
|
thanks @nisdas ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of implementing beacon state v3 (version: Merge) pkg. This PR adds all field roots related functionalities. These files are essentially duplicated from v2
As a reviewer, please cross check they are correctly duplicated from v2