Revert #9830 #9931
Merged
Revert #9830 #9931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
added
Ready For Review
potuz
approved these changes
Nov 24, 2021
terencechain
requested changes
Nov 24, 2021
There was a problem hiding this comment.
#9830 was a spec requirement (ethereum/consensus-specs#2183) i dont think we should treat this as a simple revert, I think the better course of action will be:
1.) document this in an issue
2.) communicate this with other client teams
3.) get feedbacks
4.) then revert or find better alternatives
prestonvanloon
approved these changes
Nov 24, 2021
terencechain
approved these changes
Nov 24, 2021
|
I can now verify, that v.2.0.4 solves the high bandwith problem, which has been new in v.2.0.3. Especially upstream is now back to old levels: Longer Scale (jump is the update from v.2.0.2 to v.2.0.3):
After upgrading from v.2.0.3 to v.2.0.4, back close to levels from v.2.0.2:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
While #9830 was following the consensus spec changes, it also quadrupled bandwidth requirements in certain situations for nodes. Beacon nodes now show significant increases in outbound traffic which was narrowed down to the large increases in
attestion_aggregate_proofre-propagation.Which issues(s) does this PR fix?
N.A
Other notes for review