-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Middleware for Keymanager Standard API Endpoints #9936
Conversation
2f7347e
to
e5b3df2
Compare
…prysm into api-middleware-keymanager
(cherry picked from commit 3b1f659)
…prysm into api-middleware-keymanager
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the only thing that stood out to me was that we need to remember to add put and patch as accessible functions and currently assumes put and patch as a post.. which may result in undesired effects if we don't remember to update.
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't see anything that stood out to me and radek gave blessings
WithMaxCallRecvMsgSize(maxCallSize) | ||
opts := []apigateway.Option{ | ||
apigateway.WithGatewayAddr(gatewayAddress), | ||
apigateway.WithRemoteAddr(selfAddress), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh this looks a lot more clear
This PR adds API middleware support for our keymanager standard https://ethereum.github.io/keymanager-APIs/#/ to support translating grpc gateway responses into the expected types, such as hex strings and enums, to align with the
standard.
Changes
Requirements
https://gist.github.com/rauljordan/89b35a15032dedd77cf14cfec9886c18