Ensure Slashing Protection Exports and Keymanager API Work According to Spec #9938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
reviewed
Nov 24, 2021
rauljordan
commented
Nov 24, 2021
rauljordan
commented
Nov 24, 2021
| keys []*keyCase | ||
| wantStatuses []ethpbservice.DeletedKeystoreStatus_Status | ||
| }{ | ||
| { |
There was a problem hiding this comment.
Table driven test to match what the specification wants
|
Ready @james-prysm |
james-prysm
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As defined in the validator keymanager API standard, there are a few intricate details that we must ensure we support and behave as required. This PR adds a few fixes to ensure the behavior is up to spec:
For
ImportKeystoresImportKeystoresendpoint has a corresponding password. Even if using one password to encrypt everything, we should just duplicate that password N times in the request where N = len(keystores)For
DeleteKeystores