Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rest of the merge state implementation #9939

Merged
merged 13 commits into from
Nov 25, 2021
Merged

Rest of the merge state implementation #9939

merged 13 commits into from
Nov 25, 2021

Conversation

terencechain
Copy link
Member

This PR adds rest of the merge beacon state trie implementation

  • Adds copy
  • Adds hash tree root
  • Adds bunch of missing tests from before

@terencechain terencechain added Ready For Review A pull request ready for code review Merge PRs related to the great milestone the merge labels Nov 24, 2021
@terencechain terencechain self-assigned this Nov 24, 2021
@terencechain terencechain requested a review from a team as a code owner November 24, 2021 19:49
potuz
potuz reviewed Nov 25, 2021
View reviewed changes
Copy link
Contributor

@potuz potuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

computeFieldRoots and rootSelector also take a context.Context in V2.

I'm only highlighting the differences with the V2 implementation that seemed relevant, specially in the Copy method as you're not increasing the state cound

beacon-chain/state/v3/state_trie.go Outdated Show resolved Hide resolved
beacon-chain/state/v3/state_trie.go Show resolved Hide resolved
@potuz potuz merged commit f42227a into develop Nov 25, 2021
@delete-merged-branch delete-merged-branch bot deleted the merge-state-6 branch November 25, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potuz potuz potuz approved these changes

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon prestonvanloon is a code owner automatically assigned from prysmaticlabs/core-team

@rkapka rkapka Awaiting requested review from rkapka rkapka is a code owner automatically assigned from prysmaticlabs/core-team

Assignees

@terencechain terencechain

Labels
Merge PRs related to the great milestone the merge Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@terencechain @potuz