Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow requests for next sync committee #9945

Merged
merged 4 commits into from
Nov 28, 2021
Merged

Conversation

potuz
Copy link
Contributor

@potuz potuz commented Nov 26, 2021

Fixes #9940

Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the conditions are reasonable; we can further clean it up. One thing we should address is the misuse of epoch and period

beacon-chain/rpc/eth/beacon/sync_committee.go Outdated Show resolved Hide resolved
beacon-chain/rpc/eth/beacon/sync_committee.go Outdated Show resolved Hide resolved
@@ -75,6 +122,28 @@ func currentCommitteeIndicesFromState(st state.BeaconState) ([]types.ValidatorIn
return committeeIndices, committee, nil
}

func nextCommitteeIndicesFromState(st state.BeaconState) ([]types.ValidatorIndex, *ethpbalpha.SyncCommittee, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's already a similar helper out there, and I will double-check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a similar one in the blockchain package but since the rpc package uses a helper like this for the current committee I figured it was better to mimic here

@potuz potuz added Ready For Review A pull request ready for code review OK to merge labels Nov 27, 2021
Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@prylabs-bulldozer prylabs-bulldozer bot merged commit 5983d0a into develop Nov 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the future_sync_endpoint branch November 28, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

future sync committee membership API returns invalid state id error
2 participants