New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncap error messages #9952

Merged

terencechain merged 1 commit into develop from uncap

Nov 30, 2021

Member

terencechain commented Nov 30, 2021

In most cases, a simple error return string should not be capitalized.

https://programmerah.com/golang-warning-error-string-should-not-be-capitalized-or-end-with-punctuation-mark-29739/


          Uncap error messages

897c920

terencechain requested a review from a team as a code owner

November 30, 2021 15:07

terencechain requested review from kasey, jmozah and prestonvanloon

November 30, 2021 15:07

potuz approved these changes

View reviewed changes

Contributor

potuz left a comment

I am happy to approve this, but

terencechain merged commit 0e72938 into develop

delete-merged-branch bot deleted the uncap branch

November 30, 2021 15:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

potuz potuz approved these changes

kasey Awaiting requested review from kasey kasey is a code owner automatically assigned from prysmaticlabs/core-team

jmozah Awaiting requested review from jmozah jmozah is a code owner automatically assigned from prysmaticlabs/core-team

prestonvanloon Awaiting requested review from prestonvanloon prestonvanloon is a code owner automatically assigned from prysmaticlabs/core-team