Remove Balances Timeout #9957
Merged
Remove Balances Timeout #9957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Cleanup
What does this PR do? Why is it needed?
Currently our validator balances rpc method is the only one which applies this timeout. The initial rationale given was to prevent expensive rpc requests from taking up all the node's resources. However given that this is the only method which has a timeout, the special casing doesn't make sense. It is an accepted fact by users that if they do indeed perform historical queries on the default parameters, the requests will take a longer time to be executed. This PR chooses to remove the balance timeout
for this reason.
Which issues(s) does this PR fix?
N.A
Other notes for review