Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add v1alpha1_to_v2.go #9966

Merged
merged 4 commits into from
Dec 1, 2021
Merged

Add v1alpha1_to_v2.go #9966

merged 4 commits into from
Dec 1, 2021

Conversation

potuz
Copy link
Contributor

@potuz potuz commented Dec 1, 2021

In anticipation for the merge, moving the migration tools from v1alpha <---> v2 to a separate file.

@potuz potuz requested a review from a team as a code owner December 1, 2021 16:45
@potuz potuz requested review from kasey, jmozah and rkapka December 1, 2021 16:45
rkapka
rkapka previously approved these changes Dec 1, 2021
View reviewed changes
@rkapka rkapka dismissed their stale review December 1, 2021 16:48

forgot about tests

rkapka
rkapka requested changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@rkapka rkapka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to move tests to a new file.

@prylabs-bulldozer prylabs-bulldozer bot merged commit 6ffba5c into develop Dec 1, 2021
@delete-merged-branch delete-merged-branch bot deleted the migration_v1alpha_to_v2 branch December 1, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkapka rkapka rkapka approved these changes

@kasey kasey Awaiting requested review from kasey kasey is a code owner automatically assigned from prysmaticlabs/core-team

@jmozah jmozah Awaiting requested review from jmozah jmozah is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@potuz @rkapka