Filter Errored Keys from Returned Slashing Protection History in Standard API #9968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
added
OK to merge
Ready For Review
terencechain
reviewed
Dec 2, 2021
| @@ -90,7 +90,13 @@ func (s *Server) DeleteKeystores( | |||
| if err != nil { | |||
| return nil, status.Errorf(codes.Internal, "Could not delete keys: %v", err) | |||
| } | |||
| keysToFilter := req.PublicKeys | |||
| // We select keys that were deleted for retrieving slashing protection history. | |||
There was a problem hiding this comment.
Should we add a unit test for this?
There was a problem hiding this comment.
In description: The Prysm delete keystores underlying logic never returns an error, so it is not possible to add a unit test for this logic, unfortunately. Nevertheless, we should still implement the expected behavior.. So we cant add tests for this that would test this code branch, but it's important to have this logic
james-prysm
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the validator keymanager API, in the
DeleteKeystoresendpoint: when we attempt to delete some keystores, saya, b, c, and a single keystoreb, has an ERROR status when deleting, anda, care deleted successfully, we only want to return slashing protection history fora, c.NOTES: The Prysm delete keystores underlying logic never returns an error, so it is not possible to add a unit test for this logic, unfortunately. Nevertheless, we should still implement the expected behavior.