Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup #9992

Merged
merged 13 commits into from
Dec 7, 2021
Merged

Code cleanup #9992

merged 13 commits into from
Dec 7, 2021

Conversation

rkapka
Copy link
Contributor

@rkapka rkapka commented Dec 7, 2021 •
edited

What type of PR is this?

Cleanup

What does this PR do? Why is it needed?

Fixes several Deepsource issues:

  • Value assigned to a variable is never read before being overwritten
  • The result of append is not used anywhere
  • Suspicious assignment of range-loop vars detected
  • Unused method receiver detected
  • Method modifies receiver
  • Duplicate imports detected
  • Incorrectly formatted error string
  • Types of function parameters can be combined
  • Unused parameter detected in function

@rkapka rkapka added the Cleanup Code health! label Dec 7, 2021
@rkapka rkapka requested a review from a team as a code owner December 7, 2021 16:01
@rkapka rkapka added OK to merge Ready For Review A pull request ready for code review labels Dec 7, 2021
@prylabs-bulldozer prylabs-bulldozer bot merged commit 5569a68 into develop Dec 7, 2021
@delete-merged-branch delete-merged-branch bot deleted the code-cleanup branch December 7, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan approved these changes

@kasey kasey Awaiting requested review from kasey kasey is a code owner automatically assigned from prysmaticlabs/core-team

@terencechain terencechain Awaiting requested review from terencechain terencechain is a code owner automatically assigned from prysmaticlabs/core-team

@nisdas nisdas Awaiting requested review from nisdas nisdas is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
Cleanup Code health! Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rkapka @rauljordan