Fixing Rename Refactorings #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename WorkspaceRenameEdits => WorkspaceOperations - Removes dead variable - Use `merge` to accumulate changes to the operations - Only convert once - Use IteratorAggregate instead of extending ArrayIterator
...i.e. LocatedTextDocuemntEdits maps to the LSP TextDocumentEdits
dantleech
force-pushed
the
fix-will-rename-dan
branch
from
408debe
to
8e7b819
Compare
|
Looks fine at first glance but I get incomplete response (without text edits), for example {
documentChanges = { {
kind = "rename",
newUri = "file:///tmp/phpactor-dirty/lib/Name/Phpactor2.php",
oldUri = "file:///tmp/phpactor-dirty/lib/Phpactor.php"
} }
}and haven't check why yet. |
Co-authored-by: Tomasz N <przepompownia@users.noreply.github.com>
|
feel free to merge and change :) |
Co-authored-by: Tomasz N <przepompownia@users.noreply.github.com>
przepompownia
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mergeto accumulate changes to the operationsand finally makes the unit of operation the LocatedTextDocumentEdits and not the LocatedTextDocumentEditsMap