Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config function does not exist (1.20.4) #29

Closed
LoveToHateYou opened this issue Jan 7, 2024 · 9 comments
Closed

config function does not exist (1.20.4) #29

LoveToHateYou opened this issue Jan 7, 2024 · 9 comments
Labels
bug Something isn't working

Comments

@LoveToHateYou
Copy link

LoveToHateYou commented Jan 7, 2024

sorry if this is stupid, but for some reason I can't use the config command to change the settings for the datapack, all the other functions are visible, but '/function ps-mob:config' doesn't work and I get 'Unknown function ps-mob:config'

@PuckiSilver
Copy link
Member

Strange, do you have any other mods installed? Did you try rejoining the world/restarting the server or running /reload?

@PuckiSilver PuckiSilver added bug Something isn't working help wanted Extra attention is needed labels Jan 7, 2024
@LoveToHateYou
Copy link
Author

LoveToHateYou commented Jan 7, 2024

I'm using the datapack version, no other mods or datapacks installed aside from performance mods and the ones people use like AppleSkin, 3d-Skin-Layers, BetterF3, etc...

short video: https://youtu.be/aahQ_1H-yOY

I can still use the scoreboard commands to change stuff, but the function command doesn't work

also another thing, how rare are the drops from mobs? I was testing with increased spawn rate for the captains in creative and after constant killing for like 2 hours I was not able to get a drop

I want to be able to use this in a realm with friends

@PuckiSilver
Copy link
Member

That is indeed strange, I'll look into it, maybe something in 1.20.4 did break the data pack.

The mobs should also drop a piece of gear every time you kill them, so that seems to also be bugged.

Only thing you can try - would be in fully vanilla but it doesn't look like it would change that.

I will update the mod for the newest versions when I get the time, sorry for the inconvenience!

@PuckiSilver PuckiSilver removed the help wanted Extra attention is needed label Jan 7, 2024
@setzke
Copy link

setzke commented Jan 10, 2024

I'm in full vanilla (1.20.4) with some datapacks and I noticed there's no config.
My issue may be different, though -- I've noticed no activation of the datapack, yet. Figured I'd fiddle with config to try to activate it.
image
image
image

@setzke
Copy link

setzke commented Jan 10, 2024

One of my worlds did work so I'm a bit baffled. Too lazy to go back into that one right now (sorry!)
I will offer, this, though. I deactivated all resource packs, loaded only MobCaptains datapack (Modrinth), and created a new world in Vanilla 1.20.4. Here's the log:
https://pastebin.com/9uFbnrEU

image

Update:
In the new world, I left the game running and heard one of your mobs spawn. I wasn't around to visually confirm it, but it looks like the datapack is at least partially running:
image

@setzke
Copy link

setzke commented Jan 10, 2024

Fix for loot tables is to remove the "quotation marks" from every instance of "true" and "false"
image

@PuckiSilver
Copy link
Member

Thanks for figuring that out, they changed validation of too many or too little quotes in the 1.20.3 snapshots, that probably breaks the config and the loot tables, so the fix will be similar for both.

@setzke
Copy link

setzke commented Jan 10, 2024

Fixed the config -- you have "suggest_legendary" instead of "suggest_command".
I don't know JSON, so I was butchering this document up down left and right, only to stumble onto this "oh duh" error towards the end. 😅

Thanks, Mojang!
image

@PuckiSilver
Copy link
Member

PuckiSilver commented Jan 10, 2024

This all should be fixed in v3.1.0, thank y'all for pointing out the errors, please re-open if the errors persist
https://modrinth.com/datapack/mob-captains/version/v3.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants