refactor: switched from inversify to nestjs #626

microwavekonijn · 2022-09-22T19:36:54Z

Inversify while really feature rich is just a terrible idea for this project. I refactored the code with minimal changes so it uses NestJS, which is inline with other projects like the API and the Kafka collector. We are also able to use the full arsenal of what NestJS has to offer like microservices for instance.

Switched to NestJS for IoC;
Switched to the NestJS Logger(deprecating Winston);
Fixed linting errors.

Some items require attention:

Some redundant dependencies: body-parser, cli-color, clone, and cors;
Maybe a revisit with regards to the Eslint config as the situation is just nasty(maybe add Prettier);
Modularization of the Aggregator with SoC in mind, can be postponed(the majority of the providers are put in the root);
Test run the refactor(didn't get around to it);
Some configuration changes happened to the logger(relates to deployments).
M: Provisioning of the application will have to be re-done, various ENVs may have changed and the k8s health check has definately changed

All in all I found some looming problems while working on this which are addressed now.

Btw, the biggest changes are in the services as I added some modules there. There is also the subscribers from rabbit that have been moved to the root.

Maelstromeous

Various comments, mostly related to handling of silly log levels.

Local testing will be required for this, I'm not 100% convinced that the rabbit queues stuff will continue to work with this change, there's a lot of moving parts that, while only IoC in theory has been changed, the effect of singletons (and I'm not seeing now they're declared yet) has drastic effects on the processing.

.eslintrc.js

src/AppModule.ts

src/authorities/InstanceAuthority.ts

src/authorities/PopulationAuthority.ts

src/middlewares/index.ts

src/services/rabbitmq/queues/AdminQueue.ts

src/services/rabbitmq/queues/ApiQueue.ts

src/services/rabbitmq/queues/InstanceEventQueue.ts

src/services/rabbitmq/queues/RabbitMQQueue.ts

src/authorities/InstanceAuthority.ts

src/authorities/OverdueInstanceAuthority.ts

src/authorities/PopulationAuthority.ts

src/authorities/QueueAuthority.ts

src/brokers/ItemBroker.ts

src/calculators/LocalServerTimeCalculator.ts

src/calculators/TerritoryCalculatorAbstract.ts

src/handlers/OutfitParticipantCacheHandler.ts

src/handlers/aggregate/instance/InstancePopulationAggregate.ts

src/handlers/aggregate/instance/InstanceWeaponAggregate.ts

src/handlers/ps2census/DeathEventHandler.ts

src/main.ts

src/parsers/ZoneDataParser.ts

…at/nestjs

This reverts commit 6775f35.

…attempt to store a local cache of it for multiple lattice versions. Moved calculation of lattice version to the constants repo for common calculations. Removed hacking of Oshur data as Census provides it properly now.

Removed local server time calculations, throwback to when we used to factor in server time in brackets (which we no longer do)

…pace them. This has a benefit that Medis can group keys together for ease of administration. Refactored how census cache hits are recorded. Removed keys used in one place to describe lists and moved into their respective classes

Removed some extra logging or moved to logger

Corrected duration logic for census cache hits / misses

…named Census cache/miss to be more grammatically correct

Removed k8s templates that no longer used

refactor: switched from inversify to nestjs

ce7818c

microwavekonijn added the enhancement New feature or request label Sep 22, 2022

microwavekonijn requested a review from Maelstromeous September 22, 2022 19:36

microwavekonijn self-assigned this Sep 22, 2022

microwavekonijn added 5 commits September 22, 2022 21:38

fix: compile error

83746e4

chore: removed deprecated interfaces

953868b

chore: removed deprecated class

e93e36d

fix: potential side-effect

c2475c0

fix: throw unhandled rejections

542f1c7

Maelstromeous requested changes Sep 25, 2022

View reviewed changes