-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[idea]: if MX4SIO driver is stored on a sio/
folder. why not move sio2man and similar stuff there too?
#419
Comments
It may be related to how the modules were historically grouped. It makes sense to me, if you grouped all the SIO2 modules together. But beware that shifting files, may make viewing the Git history harder. |
Good idea for sio2man. Can you make a list of similar stuff you propose? Like would that include all memorycard and controller related modules as well? |
not sure... |
it will not change if you place it in different commit. But if you do as always by squashing, then, yes, history will loose. So in that case you should make clean commits without tons of commits that should be squashed. |
What I meant, is that you will have more obstacles when viewing the history of files that were moved, as Git treats them as being different files (a "move" is a deletion of the original and addition of the same file, under the same name). Unless your Git client is more powerful than what I know of, the standard one and the website will only show you the history of the file where it currently resides, unless you do something extra. This also affects "git blame". For these reasons, I would usually avoid having to rename or move any file in Git, unless necessary. |
I think it's best to keep things as is. I made this issue back then because it made no sense to me having sio2man inside |
Are you sure? I recently renamed some files in PMAP without loosing any git history for them: |
as title says.
just an idea that came to my mind while reading sio2man code
The text was updated successfully, but these errors were encountered: