util.c fix checking ret value of mkdir

ps2homebrew · Sep 4, 2021 · 24bfe5b · 24bfe5b
1 parent a41cc2b
commit 24bfe5b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 11 deletions.
diff --git a/src/system.c b/src/system.c
@@ -916,13 +916,13 @@ int sysExecElf(const char *path)
 
 int sysCheckMC(void)
 {
-    DIR *mc0_root_dir = opendir("mc0:");
+    DIR *mc0_root_dir = opendir("mc0:/");
     if (mc0_root_dir != NULL) {
         closedir(mc0_root_dir);
         return 0;
     }
 
-    DIR *mc1_root_dir = opendir("mc1:");
+    DIR *mc1_root_dir = opendir("mc1:/");
     if (mc1_root_dir != NULL) {
         closedir(mc1_root_dir);
         return 1;

diff --git a/src/util.c b/src/util.c
@@ -105,9 +105,9 @@ void checkMCFolder(void)
     mkdir(path, 0777);
 
     snprintf(path, sizeof(path), "mc%d:OPL/opl.icn", mcID & 1);
-    fd = open(path, O_RDONLY, 0666);
+    fd = open(path, O_RDONLY);
     if (fd < 0) {
-        fd = open(path, O_WRONLY | O_CREAT | O_TRUNC);
+        fd = openFile(path, O_WRONLY | O_CREAT | O_TRUNC);
         if (fd >= 0) {
             write(fd, &icon_icn, size_icon_icn);
             close(fd);
@@ -117,9 +117,9 @@ void checkMCFolder(void)
     }
 
     snprintf(path, sizeof(path), "mc%d:OPL/icon.sys", mcID & 1);
-    fd = open(path, O_RDONLY, 0666);
+    fd = open(path, O_RDONLY);
     if (fd < 0) {
-        fd = open(path, O_WRONLY | O_CREAT | O_TRUNC);
+        fd = openFile(path, O_WRONLY | O_CREAT | O_TRUNC);
         if (fd >= 0) {
             write(fd, &icon_sys, size_icon_sys);
             close(fd);
@@ -151,11 +151,13 @@ static int checkFile(char *path, int mode)
             if (pos) {
                 memcpy(dirPath, path, (pos - path));
                 dirPath[(pos - path)] = '\0';
-                int res = mkdir(dirPath, 0777);
-                // Non-standard POSIX check: the error value is supposed to be assigned to errno, not the return value
-                if (res >= 0 || res == -EEXIST) {
-                    return 0;
-                }
+                DIR *dir = opendir(dirPath);
+                if (dir == NULL) {
+                    int res = mkdir(dirPath, 0777);
+                    if (res != 0)
+                        return 0;
+                } else
+                    closedir(dir);
             }
         }
     }