Skip to content

Commit

Permalink
CDVDFSV: reduced stack size for RPC thread 0 and 1, from 0x1900 to 0x…
Browse files Browse the repository at this point in the history
…500 and 0x800 to 0x400 respectively. These RPCs do not call functions that trigger callbacks, so it is not necessary to preserve their original stack sizes.
  • Loading branch information
sp193 committed Sep 29, 2018
1 parent 5251100 commit d25a8ea
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions modules/iopcore/cdvdfsv/cdvdfsv.c
Expand Up @@ -259,7 +259,7 @@ static void cdvdfsv_startrpcthreads(void)
thread_param.attr = TH_C;
thread_param.option = 0xABCD8001;
thread_param.thread = (void *)cdvdfsv_rpc1_th;
thread_param.stacksize = 0x1900;
thread_param.stacksize = 0x500; //Original: 0x1900. Its operations probably won't need so much space, since its functions will never trigger a callback.
thread_param.priority = 0x51;

rpc1_thread_id = CreateThread(&thread_param);
Expand All @@ -277,7 +277,7 @@ static void cdvdfsv_startrpcthreads(void)
thread_param.attr = TH_C;
thread_param.option = 0xABCD8000;
thread_param.thread = (void *)cdvdfsv_rpc0_th;
thread_param.stacksize = 0x800;
thread_param.stacksize = 0x400; //Original: 0x800. Its operations probably won't need so much space, since its functions will never trigger a callback.
thread_param.priority = 0x51;

rpc0_thread_id = CreateThread(&thread_param);
Expand Down

1 comment on commit d25a8ea

@rickgaiser
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't load any games over SMB after this change. For instance "007 Quantum of Solace", "Burnout Revenge" and "GT4".

Please sign in to comment.