Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Bug #214

Closed
KrahJohlito opened this issue Sep 1, 2019 · 3 comments
Closed

Language Bug #214

KrahJohlito opened this issue Sep 1, 2019 · 3 comments

Comments

@KrahJohlito
Copy link
Member

KrahJohlito commented Sep 1, 2019

Issue checklist

Note: these are not necessarily requirements

Open PS2 loader version

Current

Open PS2 loader mode (USB, SMB, HDD)

USB, SMB, HDD

Open PS2 type (Normal, Childproof, VMC, GSM, PS2RD)

All

Issue description - Describe the problem you are having

So.. I inadvertently created a bug with the language update, when saving an external language that is booted from a device other than MC to OPL config, upon next boot up there will be no font rendered...
thanks to @Tupakaveli for finding the bug.

I was able to narrow it down to guiUpdateScreenScale() needing to be called later in the init cycle than applyConfig is.. so by using a deferred call
ioPutRequest(IO_CUSTOM_SIMPLEACTION, &guiUpdateScreenScale);
after _loadConfig() in init.. this fixes the bug..

I just wanted to run it past you guys for approval before I make a pull request.

@rickgaiser (sorry I know you're busy with newlib)
@sp193 (sorry I know you're busy in general)

Cheers guys

@J013k
Copy link
Contributor

J013k commented Sep 2, 2019

I totally forgot about this check.
I've the same issues as it is described.

Anyway, theoretically loading themes is (currently) almost identical to languages\translations,
so I don't know if this another issues might also effect some other stuff:
https://www.psx-place.com/threads/open-ps2-loader-v0-9-3.13415/page-41#post-202250.

@KrahJohlito
Copy link
Member Author

resolved in upcoming pull request

@J013k
Copy link
Contributor

J013k commented Sep 21, 2019

Theoretically this problem still exists.
I mean after fixing thm, something was messed up once again in lng.

EDIT: Fixed in this pull request:
#222.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants