Reverting the shifting of smb_Disconnect() from DeviceDeinit() to DeviceUnmount() #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting of smb_Disconnect() from DeviceDeinit() to DeviceUnmount() seems to prevent this. It may be also related to the IOP reboot, since this function is called from the _exit() function, which is called when the module is unloaded (before IOP reboots etc). Related to commit 8dbaaae.
|
Tested VMC with GT4 (SCUS) in SMB mode and its working fine! |
|
I've tried these reverted changes with Gran Turismo 3 (SCES_502.94). Thanks. |
AKuHAK
pushed a commit
that referenced
this pull request
Sep 30, 2021
Reverting the shifting of smb_Disconnect() from DeviceDeinit() to DeviceUnmount()
citronalco
pushed a commit
to citronalco/OPL-Daily-Builds
that referenced
this pull request
Sep 10, 2023
Reverting the shifting of smb_Disconnect() from DeviceDeinit() to DeviceUnmount()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Note: these are not necessarily requirements
Pull Request description
Some games seem to exhibit VMC corruption after this change was made.
It may be also related to the IOP reboot, since this function is called from the _exit() function, which is called when the module is unloaded (before IOP reboots etc).
Related to commit 8dbaaae.
Not tested. I'm only doing this because of the comments from here.