Clang-format related changes

[uyjulian]

Pull Request checklist

Note: these are not necessarily requirements

• I reformatted the code with clang-format
• I checked to make sure my submission worked
• I am the author of submission or have permission from the original author
• Requires update of the PS2SDK
• Requires update of the gsKit
• Others (please specify below)

Pull Request description

Added sections to not run clang-format on.
Added a new Makefile rule to run clang-format.
Adds formatting check to continuous integration.
Run clang-format on files.

[ElPatas1]

I can't merge this pull request, appears the message of:
"This branch has conflicts that must be resolved."

Best regards.

[uyjulian]

Don't merge it yet. I'd like to wait for a few more comments and for libc changes to get merged.

On Mon, Jan 27, 2020 at 2:18 PM ElPatas1 ***@***.***> wrote: I can't merge this pull request, appears the message of: "This branch has conflicts that must be resolved." Best regards. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#240>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAM4OHTGCLZ27FKELOEFS6LQ746RFANCNFSM4KLO6DYQ> .

-- -- ~Julian Uy

[ElPatas1]

I see, thank you.

Best regards.

[rickgaiser]

I like the new "format" target you added, is makes it easy for everyone to use clang-format. But why has the coding standard changed? I can understand fine-tuning the previous coding standard, or re-running the standard on all files, but this change is larger than it needs to be.

• We're already using spaces, why change it to tabs?
• Why change bracket style to Allman?

Changing this many lines of code also has a negative effect on for instance git blame or git cherry-pick. Tools I use regulary to track bugs/changes and cherry-pick commits from different branches.

[uyjulian]

I dropped the configuration changes and rebased.

[uyjulian]

Probably #287 should be merged before this. I can rebase easily

[rickgaiser]

The results of this PR look great. If you can rebase after #287 is merged I'll pull this PR.

[ElPatas1]

@uyjulian, then when #287 ir ready for merge, i merge it first and second is possible merge this pull request?
There is a conflict message now in this pull request:

"This branch has conflicts that must be resolved

Conflicting files

src/gui.c"

Best regards.

[uyjulian]

There will be a conflict when #287 is merged, so merge that first, I rebase this branch, then it is possible to merge this one.

[ElPatas1]

Hi, the PR of #287 has been merged.

Best regards.