Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with newlib #261

Merged
merged 7 commits into from
May 11, 2020

Conversation

rickgaiser
Copy link
Member

This is the PR for making OPL compatible with newlib.

ps2toolchain, ps2sdk, ps2sdk-ports and gsKit have already been updated to newlib. Please update your entire toolchain before testing this.

@ElPatas1
Copy link
Contributor

@rickgaiser, thank you very much for the work, you can provide a test build please
compiled with all this updates for we can test it?

Best regards.

@rickgaiser
Copy link
Member Author

No, sorry.

You'll have to update your toolchain anyway. If you have your toolchain updated you can test this PR with:

# Add remote repository
git remote add rickgaiser https://github.com/rickgaiser/Open-PS2-Loader
git fetch rickgaiser

# Checkout PR and test it
git checkout rickgaiser/for-ifcaro-newlib -b newlib-pr-test
make clean run

# Go back to ifcaro/master branch, and cleanup newly created PR test branch
git checkout master
git branch -d newlib-pr-test

@KrahJohlito
Copy link
Member

Built everything from scratch (toolchain, sdk, sdk-ports, gskit).. newlib port of OPL is working great, didn’t have any issues during my tests.. BMP COVs are now working without problems also. Great work!

@rickgaiser
Copy link
Member Author

I've added the bugfixes from my stable master-ps2max branch. One of them fixes the notification issue, as reported on psx-place.

Also when reverting to the previous video mode. applyConfig will check
if it's needed to reload or not.
It was causing problems when compiling OPL with the -O3 flag. Not sure
why though, but it's simpler like this.
@ElPatas1 ElPatas1 merged commit 50a93d3 into ps2homebrew:master May 11, 2020
@rickgaiser
Copy link
Member Author

Thank you for merging, now we can move on. The exit issue should still be present, so I'll make a separate issue for it.

Also note that there's a recent change in gsKit by @KrahJohlito that fixes a bmp issue. So please update everything again before releasing a build.

@rickgaiser rickgaiser deleted the for-ifcaro-newlib branch May 11, 2020 07:07
@ElPatas1
Copy link
Contributor

@rickgaiser, thank you very much, i updated all, made the merge of newlib, and compiled
the OPL just this yesterday night, all this night.

And i saw now in the gsKit repository that the bmp fix made by @KrahJohlito was
made 3 days ago, so i already have everything updated right?

Best regards.

@rickgaiser
Copy link
Member Author

Yes, if you've updated everything last night then you should have the latests of everything.

@ElPatas1
Copy link
Contributor

@rickgaiser, yes, thank you very much.

Best regards.

AKuHAK pushed a commit that referenced this pull request Sep 30, 2021
citronalco pushed a commit to citronalco/OPL-Daily-Builds that referenced this pull request Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants