Small Update...

[KrahJohlito]

Pull Request checklist

Note: these are not necessarily requirements

• I reformatted the code with clang-format
• I checked to make sure my submission worked
• I am the author of submission or have permission from the original author
• Requires update of the PS2SDK
• Requires update of the gsKit
• Others (please specify below)

Pull Request description

This is all I have time for, no time for screenshots..sorry. Theme changes are minimal.. allowing 64 character game titles to fit in the bounding box and basically just reverts requested by @ElPatas1 and have been placed into the internal theme cfg rather than hard coded settings.. so you won't notice much difference booting up default theme.

I actually tested this time and it seems to be working as intended.

Interesting side note: fixing the condition in checkMCFolder() seems to have stopped all 'on exit' issues for me... why would this only affect HiRes & USB? I have no idea... but its fine for me... for now at least...

Test - https://www.sendspace.com/file/nh1mps

[J013k]

Exiting from app has been fixed, but I have another problems.

• While saving settings on mc0:
  I'm getting "Settings saved to mc".
  App do not specify mc0: or mc1:.

• While loading settings from mc0:
  I'm getting "CFG loaded from mc".
  App also do not specify mc0: or mc1:.

• While saving settings on mc1:
  I'm getting "Settings saved to mc1" (without ":", mc1:).

• While loading settings from mc1:
  I'm getting "CFG loaded from mc".
  App also do not specify mc0: or mc1:.

• When I have 2 MC.
  mc0 only with e.g. save games (without OPL settings),
  mc1 with OPL settings.
  Settings from mc1 will not be loaded.

[KrahJohlito]

When I have 2 MC.
mc0 only with e.g. save games (without OPL settings),
mc1 with OPL settings.
Settings from mc1 will not be loaded.

Damn.. I guess we need to be checking folders first for this reason... it looked unnecessary but it seems we do need it.. I’ll revisit it after work.

[KrahJohlito]

Should be all good now, @J013k I updated the test link if you wanted to test it out also.. cheers

[ElPatas1]

Test build freezes on exit sometimes even if i don't save the config.
And always freezes on exit if i change a Theme and i save the config. (mc0 or mc1),
with a different theme.

Best regards.

[J013k]

Unfortunately during these workdays I have very limited time...
So sorry for my absence or long time to reply.

I have almost similar results as @ElPatas1 have.
I mean OPL after exiting few times and on\off (enable\disable) features\options might freeze at exit:

While testing saving\loading options I do not have any problems.
CFG will be loaded from mc0:\mc1:
CFG will be saved to mc0:\mc1:
I have try 2 MC and few situations.

• MC only in 1st slot - Everything was fine
• MC only in 2nd slot - Everything was fine.
• MC with settings on 2nd MC, MC without settings on 1st slot. - Everything was fine.
• MC with settings on 1st MC, MC without settings on 2nd slot. - Everything was fine.
• Boot OPL without any MC. - Settings will be save\loaded to\from mass:, so everything was fine.

For now I do not have an access to FAT console, so I don't know how fixed saving settings will work for all devices.

[KrahJohlito]

Ok, thanks for testing. The purpose of this pull request is not to fix the exit issue it just seemed like it was working so thanks anyway.
This PR is just to fix the issues with mc1 and custom themes so feel free to merge when ready, there won’t be additional commits.

[ElPatas1]

I see, i not tested the issues concretely about mc1.

@J013k, for you saving config in mc1 works? there is not "error writing settings" anymore?
And all the issues with mc1 are fixed?

Best regards.

[J013k]

All issues with saving setting to mc1: were fixed.

I have also try pfs0: (hdd0:).
Settings will be created on that device.
Settings will be loaded from that device.

[ElPatas1]

@J013k, thank you very much.

Best regards.