Prevent implicit double conversion

[astrelsky]

Pull Request checklist

Note: these are not necessarily requirements

• I reformatted the code with clang-format
• I checked to make sure my submission worked
• I am the author of submission or have permission from the original author
• Requires update of the PS2SDK
• Requires update of the gsKit
• Others (please specify below)

Pull Request description

It may be a good idea to use -fsingle-precision-constant as a further measure to prevent this.

[rickgaiser]

Nice catch. Can you add -fsingle-precision-constant to the Makefile too?

diff --git a/Makefile b/Makefile
index 964978b..689043c 100644
--- a/Makefile
+++ b/Makefile
@@ -98,6 +98,7 @@ EE_OBJS_DIR = obj/
 EE_ASM_DIR = asm/
 
 MAPFILE = opl.map
+EE_CFLAGS = -fsingle-precision-constant
 EE_LDFLAGS += -Wl,-Map,$(MAPFILE)
 
 EE_LIBS = -L$(PS2SDK)/ports/lib -L$(GSKIT)/lib -L./lib -lgskit -ldmakit -lgskit_toolkit -lpoweroff -lfileXio -lpatches -ljpeg -lpng -lzlib -ldebug -lm -lmc -lfreetype -lvux -lcdvd -lnetman -lps2ips -laudsrv

[astrelsky]

-fsingle-precision-constant

Done. -Werror=double-promotion can be added when build with the new toolchain. It is only present in gcc 4.6.3 and up.

[rickgaiser]

Thanks, looks good. I'll try my new powers and see if I can merge this one.