Small stuff #285
Merged
Small stuff #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KrahJohlito, i tested this changes with 2 custom themes which do not have the Info page, and now the Best regards. |
citronalco
pushed a commit
to citronalco/OPL-Daily-Builds
that referenced
this pull request
Sep 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Note: these are not necessarily requirements
Pull Request description
This is to fix #276
and #280 ( thanks to @AKuHAK )
When a theme loads at boot its only refreshing the hints of the mode/device the theme was loaded from leaving the others with outdated hints from the internal theme.. Loading custom themes from MC however happens much sooner in the init cycle at thmInit() so in this case we don't need to force refresh of all modes hints.
Attribute text was displaying incorrectly for custom themes.. fixed.