Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use sio2man/padman/mcman/mcserv from ps2sdk #289

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

uyjulian
Copy link
Member

@uyjulian uyjulian commented Jul 6, 2020

Pull Request checklist

Note: these are not necessarily requirements

  • I reformatted the code with clang-format
  • I checked to make sure my submission worked
  • I am the author of submission or have permission from the original author
  • Requires update of the PS2SDK
  • Requires update of the gsKit
  • Others (please specify below)

Pull Request description

Always use sio2man, padman, mcman, and mcserv from ps2sdk.
This reduces the differences between the DTL_T10000 and non-DTL_T10000 builds of OPL.

@ElPatas1 ElPatas1 requested review from rickgaiser and removed request for rickgaiser July 7, 2020 00:34
@ElPatas1
Copy link
Contributor

ElPatas1 commented Jul 7, 2020

@uyjulian, this affects only to the OPL when it is compiled with the DTL_1000 concrete build?

Best regards.

@uyjulian
Copy link
Member Author

uyjulian commented Jul 7, 2020

No, this will make a change in the non-DTL_T10000 build.

Copy link
Member

@rickgaiser rickgaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recently ran into issues with rom0:SIO2MAN when working on sio2sd. Your change makes OPL more simple and solves 1 of my problems. Great!

@AKuHAK
Copy link
Member

AKuHAK commented Jul 7, 2020

Does this build work on the DTL-T10000? Changes affect DTL as I can see.

@uyjulian
Copy link
Member Author

uyjulian commented Jul 7, 2020

Yes, it works on DTL-T10000.

@ElPatas1 ElPatas1 merged commit 61d1ccb into ps2homebrew:master Jul 8, 2020
@zappepappe
Copy link

This commit broke VMC creation. The GUI display 0% and becomes unresponsive.

@uyjulian
Copy link
Member Author

I'll check out the issue…

citronalco pushed a commit to citronalco/OPL-Daily-Builds that referenced this pull request Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants