Small improvements to Apps system

[KrahJohlito]

Pull Request checklist

Note: these are not necessarily requirements

• I reformatted the code with clang-format
• I checked to make sure my submission worked
• I am the author of submission or have permission from the original author
• Requires update of the PS2SDK
• Requires update of the gsKit
• Others (please specify below)

Pull Request description

Closes #295 ..This isn't really a 'bug' as legacy apps system works as it is supposed to (being part of the cfg index) but I did this since it seems some people want it.

Legacy apps system will now read conf_apps.cfg from any device regardless of where your main opl cfg is.. additionally you will be able to have "appname.elf.cfg" in your CFG/CFG-DEV folder to display info page stuff (new apps system already does this..better imo).. and I also quickly added getting the app size to both the legacy app system and new app system, cause it looked weird without it.. doing things this way conf_apps.cfg could possibly be removed from the cfg index but I left it as is for now.

What do you guys reckon?

[J013k]

I have only try old method with conf_apps.cfg in the root of USB device.
So far so good.

In free time I will also try what will happens if I will have conf_apps.cfg on USB, HDD, MC.
Is there any priority system for conf_apps.cfg (MC->HDD->USB)?

[hardlevel]

Im trying it right now... its better, but I think is not there yet... I`ll make a video to show

[KrahJohlito]

@J013k currently it’s MC->USB->ETH->HDD.. I’ll change it to MC->HDD->ETH->USB when I get a chance as I think that’s the priority for other things this should probably be the same.

@hardlevel rather than make a video just write what you’re having issues with.

[J013k]

I'm not sure but ETH (SMB) was I think always at last or it was not supported:
https://bitbucket.org/ShaolinAssassin/open-ps2-loader-0.9.3-documentation-project/wiki/tree-structure.

So theoretically:
MC0 >> MC1 >> HDD >> USB >> ETH
EDIT: I have notice: basically from the faster to the slower device.

I will now have some time to check what will happens if there will be conf_apps.cfg on all devices.

So here is how loading apps look like:

• For ETH, I have smb0:/app.elf
• For mass, I have mass:/app.elf
• For HDD, I have hdd0:/app.elf
• For MC, I have mc0:/APPS/app.elf \ mc1:/APPS/app.elf

EDIT: I have notice that if I have conf_apps.cfg on USB and on ETH.
conf_apps.cfg from USB will be loaded.

I have found that If I have all devices set to manually initialize, run APPS, run USB, re-run APPS.
APPS bookmark will not be updated\refreshed.

[J013k]

Thanks @KrahJohlito for new commit\PR to test.
I will try to update this post ASAP.

[KrahJohlito]

Thanks @J013k
Priority should now be MC->HDD->ETH->USB and Refreshing apps page after manual device init should show legacy apps now.

[J013k]

Between two memory cards is there is also some kind of a priority system?
MC0 >> MC1 >> HDD >> ETH >> USB.

Anyway...
Refreshing now seems to work.
At least for legacy system.

Now also priority system works as you describe.
However I do not try HDD & MC. Only USB\ETH.

Can you tell me what for is new APPS folder?
Will all apps copied there will be somehow listed?
There is no need to manually add them into conf_apps.cfg?
OPL will create additional .cfg and list them there, like with game cache for HDD?

[KrahJohlito]

Refreshing works for new app system also, I tested it. The APPS folder is for new app system, make a folder in APPS folder E.g. OPL put OPL.ELF in there along with a file title.cfg and have two lines in that title.cfg
title=open ps2 loader
boot=OPL.ELF
Those two lines must be first but after that you can add description and everything else if you choose.. anyway that is how the new apps system is handled, conf_apps.cfg is only for the legacy app system.
Thanks for testing

[J013k]

EDIT 1: Moved into #295.

EDIT 2: I have tested old\legacy system with conf_apps.cfg on every device.
There is no crash\freeze with many conf_apps.cfg on every device.
Priority system works fine = MC0 >> MC1 >> HDD >> ETH >> USB.

Everything is working as it should.