New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language and MC fix #340
Language and MC fix #340
Conversation
|
Calling mcSync after calling mcGetInfo should return (copied from ps2sdk): So checking for -1 seems good, but what happens the second time the mc card is checked? Does it then return 0 (same card)? |
|
Yea it should return 0 but this shouldn't happen as we would already have an mcID at this point and just pass through the function https://github.com/ps2homebrew/Open-PS2-Loader/blob/master/src/util.c#L48 The second call to mcGetInfo() immediately after is checking the other slot so on first call this would also return -1 even if the first card already did as its a new card. |
Language and MC fix
Language and MC fix
Language and MC fix
Language and MC fix
Language and MC fix
Pull Request checklist
Note: these are not necessarily requirements
Pull Request description
fixes #321 as seen here the first call to mcGetInfo() returns a value of -1 if a formatted mc is found.
Languages were freeing based on number of valid entries for the newly selected language rather than the one being freed.