Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve debugging, fix #339 and workaround #300 #342

Merged
merged 5 commits into from
Jan 1, 2021

Conversation

rickgaiser
Copy link
Member

@rickgaiser rickgaiser commented Dec 29, 2020

  1. workaround [ISSUE] OPL is taking a lot of time to boot using USB #300: I've disabled requesting the filesize, as this makes loading the list of games very slow. If we want to have the filesize shown in the info page we need to request it per-game, or even delayed just like the ART.
  2. Structures used by assembly code where not packed. This could cause alignment issues it a compiler tries to optimize it (gcc10)
  3. All the parameters passed to the ee_core are now printed in debug builds. The results are interesting and usefull ;).
  4. fix [ISSUE]Rendering special characters of language font files is broken #339
  5. Load debug drivers before loading storage drivers, so they can also be debugged.

EDIT: Commit 5. Added

@rickgaiser
Copy link
Member Author

I've pulled @KrahJohlito changes and rebased these on top of them. For the curious, the extra debug of parameters passed to ee_core look like this:

Starting ee_core with following arguments:
[0] ETH_MODE 0 Browser 20 192.168.1.103 255.255.255.0 192.168.1.1 0 0 0 0, 0
[1] 2147505996 2147540088
[2] 618496 783808
[3] SLUS_212.42
[4] 0
[5] 1 2 0 7874698008519356 56154283650848769 1 0 0 1 1 0
[6] cdrom0:\SLUS_212.42;1

@TnA-Plastic
Copy link

TnA-Plastic commented Dec 29, 2020

Is there a list of what [0] - [6] are (specifically 1, 2, 4, 5)?

@rickgaiser
Copy link
Member Author

You'll have to look at the code for details. It's not for users, but for developer trying to debug. It basically looks like this:
[0] = config_str
[1] = KernelConfig
[2] = ModStorageConfig
[3] = filename
[4] = compatflags
[5] = gsm_config_str
[6] = "rom0:PS2LOGO" <- but only if option is enabled!
[6/7] = ElfPath

So we can debug the drivers also.
@TnA-Plastic
Copy link

TnA-Plastic commented Dec 29, 2020

I'm sorry.
My connection is severely limited and I'm on my phone.
If I try to look at bigger files/sources it crashes/freezes Chrome.

But admittedly I was also a lazy fella and rather just asked out of curiosity (before trying to look at the source).

THX for the list (and the commits)!👍

@rickgaiser
Copy link
Member Author

Can someone merge this PR? I prefer not to merge my own changes.

@Tupakaveli Tupakaveli merged commit 5a8b4f9 into ps2homebrew:master Jan 1, 2021
@rickgaiser rickgaiser linked an issue Jan 3, 2021 that may be closed by this pull request
AKuHAK pushed a commit that referenced this pull request Sep 30, 2021
Improve debugging, fix #339 and workaround #300
citronalco pushed a commit to citronalco/OPL-Daily-Builds that referenced this pull request Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants