Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for gcc10 and more #354

Merged
merged 11 commits into from Jan 10, 2021
Merged

Fixes for gcc10 and more #354

merged 11 commits into from Jan 10, 2021

Conversation

rickgaiser
Copy link
Member

Since yesterday the EE toolchain on ps2dev has been updated to gcc10. This has broken the 'latest' builds.

These commits will:

  • FIX: most issues with gcc10
  • FIX: the filesize issue (unfortunately not backwards compatible to v1.0.0 / v1.0.1)
  • FIX: CI rebuilds (triggered from ps2dev) to be called 'latest'
  • Change: enable IGS and PADEMU by default (just like make release already does, see commit for more info)

Closes #345

@J013k
Copy link
Contributor

J013k commented Jan 9, 2021

This fix for the filesize issue seems to work with ISO.
While with ul:
https://i.postimg.cc/XqbmFbmr/size-1.png

It seems that the same situation was before (I mean before this problem with getting a file size started).

BTW OPL boots really fast and everything is fluid in games lists.

@rickgaiser
Copy link
Member Author

It seems that the same situation was before (I mean before this problem with getting a file size started).

Correct. ISO's are scanned, and while scanning the entire directory for files we get the filesize for free. The "ul"/"USBLD" or format is not scanned, but read using "ul.cfg". This file does not contain file sizes.

@J013k
Copy link
Contributor

J013k commented Jan 9, 2021

It was mainly my curiosity because there was a version which can get a file size even from .ul.
OPL_1577-Beta-e689b44:
https://i.postimg.cc/bN92WhzT/Size-3-OPL.png
Unfortunately getting a file size could take little time in this version...

@uyjulian
Copy link
Member

Looks good, merging.

@uyjulian uyjulian merged commit 309da00 into ps2homebrew:master Jan 10, 2021
AKuHAK pushed a commit that referenced this pull request Sep 30, 2021
@uyjulian
Merge pull request #354 from rickgaiser/for-ps2homebrew
a5f7b6f 
Fixes for gcc10 and more
citronalco pushed a commit to citronalco/OPL-Daily-Builds that referenced this pull request Sep 10, 2023
@uyjulian
Merge pull request ps2homebrew#354 from rickgaiser/for-ps2homebrew
e179212 
Fixes for gcc10 and more
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ISSUE] File size of games not shown
3 participants
@rickgaiser @J013k @uyjulian