USBExtreme format extended: #485
Conversation
|
@HowlingWolfHWC you might be interested in this |
There was a problem hiding this comment.
Edit: oh I see, startup format appears to be ul.SLUS_123.45 so that’s why it was and needs to be 15 https://github.com/ps2homebrew/Open-PS2-Loader/blob/master/src/supportbase.c#L622
So everything is fine? |
|
Lol sorry I know that was confusing.. it’s just https://github.com/ps2homebrew/Open-PS2-Loader/blob/master/src/supportbase.c#L630 here that needs to be updated with your new changes since magic and startup are separate edit: can’t multiline quote on my phone and my kid keeps taking it away.. but I’m sure you see what I mean, the whole function.. ul. Should be copied to magic and startup doesn’t need start copying to startup[3].. manual null after strncpy etc etc |
oh, thanks, totally missed that function. |
|
Probably I will remove that extended size handling as it seems that no one will use it, and implementation is a bit difficult for me :) |
src/supportbase.c
Outdated
|
|
||
| for (i = 0; i < gamecount; i++) { | ||
| game = &(*list)[i]; | ||
|
|
||
| if (game->format == GAME_FORMAT_USBLD && (i != excludeID)) { | ||
| memset(&GameEntry.startup[3], 0, GAME_STARTUP_MAX); | ||
| memcpy(GameEntry.startup, game->startup, GAME_STARTUP_MAX); | ||
| GameEntry.startup[GAME_STARTUP_MAX] = '\0'; |
There was a problem hiding this comment.
Still got an overflow mate, array gotta be -1
There was a problem hiding this comment.
I learned tech a bit (google is my friend) and until we treat char sequence as a string everything is fine - we can do any operations (like fwrite, read, memcpy) without terminating NULL. But once we use the string function then it depends on the compiler, but in most cases, it will fill the string with the ending NULL character. So basically in our case GameEntry.name and GameEntry.startup is a character array, while game->name and game->startup can be both: and a character array, and a string. So what I finally mean, we should not call any string-based function, cause it will silently convert any char array into a string with terminating NULL. But using memcpy and fread, fwrite is valid usage and C compliant.
|
Sounds good to me, even if the app is updated to allow space for null it would break compatibly with older versions.. Good to go yea? |
|
I’ve gone ahead and reverted the change so if you wanna continue working on this you can take your time and latest won’t be bugged. |
CRC32 function guarded from overflow
|
Ok I tested it on real hardware - now USBExtreme games will show their real size in properties. Nothing is broken (as I know), so probably if code is ok, this PR can be merged. |
USBExtreme format extended:
-added 2 byte value for game size in MiB in USBExtreme header
-skip non-valid entries in ul.cfg (useful for static size ul.cfg with empty records)
Pull Request checklist
Note: these are not necessarily requirements
Pull Request description