Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix memory cards #522

Merged
merged 3 commits into from Aug 30, 2021
Merged

fix memory cards #522

merged 3 commits into from Aug 30, 2021

Conversation

KrahJohlito
Copy link
Member

@KrahJohlito KrahJohlito commented Aug 30, 2021

Pull Request checklist

Note: these are not necessarily requirements

  • I reformatted the code with clang-format
  • I checked to make sure my submission worked
  • I am the author of submission or have permission from the original author
  • Requires update of the PS2SDK
  • Requires update of the gsKit
  • Others (please specify below)

Pull Request description

Fixes #497
Update Include for GetRomName()
Remove (now) unused #define
Fix mcID failing to resolve when no OPL folder on root of mcs.
Remove writeMCIcon(), at the point this is called we've already got the mcID so calling openFile() with mc? is pointless.
Fix: in create mode we check if file directory exists and if not create just the dir, not the whole file as a dir.
gui.c fix comparison to int.
Fix error in polish lang file.

Best Regards

@rickgaiser
Copy link
Member

Code looks good to me, @J013k can you check functionality?

@J013k
Copy link
Contributor

J013k commented Aug 30, 2021

@rickgaiser I have already done it:
#497 (comment).
Everything is fine.

I only have this "weird thing":
#497 (comment).
But it is not related to this PR, because it has been happening before although not in OPL v1.0.0.
I do not remember exactly when it started....
I can open a new issue for that if you like... or maybe it is not fully an issue?

Additionally also PL translation has been fixed thanks to this PR.

@rickgaiser
Copy link
Member

As long as the "weird thing" is not causing any issues and has been a "weird thing" for a long time, I think we can leave it at that. Thanks for the PR and testing, merging.

@rickgaiser rickgaiser merged commit 69ba293 into ps2homebrew:master Aug 30, 2021
AKuHAK pushed a commit that referenced this pull request Sep 30, 2021
citronalco pushed a commit to citronalco/OPL-Daily-Builds that referenced this pull request Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE]: OPL creates folders on a memory card
3 participants